[SYCL][NFC] Move kernel launch property parsing out of sycl::handler

[uditagarwal97]

Motivation is to decouple kernel launch property parsing from sycl::handler so that we can reuse this code for no-handler submission path.

[Copilot]

Pull Request Overview

This PR refactors kernel launch property parsing to move it out of the sycl::handler class into a separate helper structure for better code organization and reusability. The motivation is to enable reuse of kernel launch property parsing code in no-handler submission paths.

Key Changes:

• Creates KernelLaunchPropertyWrapper struct to encapsulate property parsing logic
• Converts kernel launch properties to use std::optional to track if properties have been set
• Updates all references to kernel properties to use the new structure with dereferencing

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
sycl/include/sycl/detail/kernel_launch_helper.hpp	Implements new KernelLaunchPropertyWrapper with property parsing methods
sycl/include/sycl/handler.hpp	Updates handler to use new property wrapper and adds helper methods
sycl/source/detail/handler_impl.hpp	Makes handler_impl inherit from KernelLaunchPropertyWrapper
sycl/source/handler.cpp	Updates property handling to use new structure and adds property setter method
sycl/unittests/scheduler/*.cpp	Updates mock handlers to dereference optional kernel properties
sycl/test/virtual-functions/properties-negative.cpp	Updates expected error location from handler.hpp to kernel_launch_helper.hpp
sycl/test/extensions/properties/non_esimd_kernel_fp_control.cpp	Updates expected error location
sycl/test/include_deps/sycl_detail_core.hpp.cpp	Adjusts include dependency ordering
sycl/unittests/program_manager/arg_mask/EliminatedArgMask.cpp	Updates mock handler to use dereferenced properties

[Copilot]

The custom assignment operator should have a corresponding custom copy constructor, destructor, and move operations following the Rule of Five, or use the default implementations if possible.

[aelovikov-intel]

Yeah, why not = default;?

[aelovikov-intel]

Needs a test under sycl/test/abi/** then.

[aelovikov-intel]

Suggested change

	// In some code paths, kernel launch properties are set multiple times
	// for the same kernel, i.e why using std::optional to avoid overriding
	// previously set properties.
	// In some code paths, kernel launch properties are set multiple times
	// for the same kernel, that is why using std::optional to avoid overriding
	// previously set properties.

However, why not fix multiple parsing instead?

[aelovikov-intel]

Yeah, why not = default;?

[aelovikov-intel]

MKernel* made sense when it was part of handler, now that the class itself is specific for the kernel properties, you can name properties without "Kernel" in them, e.g. MIsCooperative.

[aelovikov-intel]

This looks ugly now, but I'm not yet sure what would be a better approach.

[uditagarwal97]

I can try inline throwIfGraphAssociated in processLaunchProperties as it's just used twice.

[aelovikov-intel]

PropertyProcessorPtrT needs more documentation in the comment above. What you could also do is

template <typename Self>
struct PropertiesProcessor {
  void foo() {
    using self = static_cast<Self *>(this);
    self->bar();
  }
};

struct handler : public PropertiesProcessor<handler> { ... };

IIUC what you're trying to achieve here.

[aelovikov-intel]

I was thinking about inlining launch properties processing before, but it makes even less sense to have them separate now.

[aelovikov-intel]

I wanted to add that when working with postProcess refactoring, but ultimately decided it was a wrong abstraction. Wouldn't be surprised if the same is true here.

[aelovikov-intel]

optional part needs a dedicated comment (near parseProperties, I'd think). Is that a performance optimization?

[aelovikov-intel]

Please make sure to have a local e2e run with split build/run mode where build is done with the sycl-toolchain built before this PR and run is using libsycl.so with this PR's changes.