[UR][Offload] Event waiting #19594
Open
[UR][Offload] Event waiting #19594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Implement urEventsWait[WithBarrier] and respect the waitlist of enqueue functions.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
reviewed
Jul 25, 2025
|
|
||
| olWaitEvents(Queue, OlEvents.data(), NumEvents); | ||
| } | ||
| return nullptr; |
There was a problem hiding this comment.
Nitpick: OL_SUCCESS is clearer to someone less familiar with the Offload API
| OlEvents.push_back(UrEvents[I]->OffloadEvent); | ||
| } | ||
|
|
||
| olWaitEvents(Queue, OlEvents.data(), NumEvents); |
There was a problem hiding this comment.
This result is never checked
|
|
||
| // Create events on each active queue for an arbitrary thread to block on | ||
| // TODO: Can we efficiently check if each thread is "finished" rather than | ||
| // creating an event? |
There was a problem hiding this comment.
stream_queue_t::syncEvents has some optimizations to only sync streams that need to be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement urEventsWait[WithBarrier] and respect the waitlist of enqueue
functions.