[SYCL] Graph recording support for handler-less kernel submission path #20250
+68
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
reviewed
Sep 30, 2025
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Oct 1, 2025
|
@intel/llvm-gatekeepers please consider merging |
1 similar comment
|
@intel/llvm-gatekeepers please consider merging |
sergey-semenov
approved these changes
Oct 6, 2025
| CodeLoc)); | ||
| CommandGroup->MIsTopCodeLoc = IsTopCodeLoc; | ||
|
|
||
| if (auto GraphImpl = getCommandGraph(); GraphImpl) { |
There was a problem hiding this comment.
Suggested change
| if (auto GraphImpl = getCommandGraph(); GraphImpl) { | |
| if (auto GraphImpl = getCommandGraph()) { |
Just a non-blocking nitpick, might just be my personal preference though.
There was a problem hiding this comment.
Thanks, I will address this in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a folllow-up PR to #19294