Skip to content

[UR][L0v2] Add initial record & replay implementation #20860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kswiecicki merged 8 commits into from
Dec 16, 2025
Merged

[UR][L0v2] Add initial record & replay implementation #20860

kswiecicki merged 8 commits into from
Dec 16, 2025

Conversation

@kswiecicki
Copy link
Contributor

@kswiecicki kswiecicki commented Dec 9, 2025

No description provided.

@kswiecicki kswiecicki requested review from a team as code owners December 9, 2025 14:26
@kswiecicki
Copy link
Contributor Author

kswiecicki commented Dec 9, 2025

@pbalcer, experimental header zex_graph.h is unavailable in when installing compute-runtime release package from https://github.com/intel/compute-runtime/releases. To avoid compilation failure involving unknown ze_graph_handle_t structure I've temporarily hardcoded compute-runtime fetching, which includes latest experimental headers.
As a final solution, should I copy this header and paste it into the L0 adapters subdirectory?

@kswiecicki
Copy link
Contributor Author

kswiecicki commented Dec 9, 2025

@lslusarczyk I've removed the UR_DFAILURE from ZE2UR_CALL_THROWS because it makes handling exception impossible when in debug mode.

@pbalcer
Copy link
Contributor

pbalcer commented Dec 9, 2025

As a final solution, should I copy this header and paste it into the L0 adapters subdirectory?

Yes, I think we should do that for all experimental level-zero APIs we use.

@kswiecicki
[UR][L0] Remove UR_DFAILURE from ZE2UR_CALL_THROWS
dd2fec7 
UR_DFAILURE aborts program before throwing an exception making it
impossible to handle it using try catch.
@kswiecicki
Remove trailing comma from known failures
3dd399b
@kswiecicki kswiecicki force-pushed the ur-l0v2-record-replay branch from 9dac854 to 1cf110b Compare December 10, 2025 10:03
@kswiecicki kswiecicki force-pushed the ur-l0v2-record-replay branch from 1cf110b to e767c1b Compare December 10, 2025 10:13
@kswiecicki kswiecicki force-pushed the ur-l0v2-record-replay branch from e767c1b to 604ad0f Compare December 10, 2025 10:29
@kswiecicki kswiecicki force-pushed the ur-l0v2-record-replay branch from 604ad0f to cf4000e Compare December 10, 2025 11:27
KFilipek
KFilipek approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

@intel/llvm-gatekeepers please consider merging

@kswiecicki kswiecicki force-pushed the ur-l0v2-record-replay branch from 919fad7 to a1fd0d9 Compare December 15, 2025 12:19
@kswiecicki kswiecicki force-pushed the ur-l0v2-record-replay branch from 80d2872 to a1fd0d9 Compare December 15, 2025 14:14
@kswiecicki
Copy link
Contributor Author

kswiecicki commented Dec 16, 2025 •
edited
Loading

SYCL Pre Commit on Linux test timeout was not caused by this PR.

Timed Out Tests (1):
  SYCL :: HostInteropTask/host-task-failure.cpp

@kswiecicki kswiecicki merged commit 0879472 into intel:sycl Dec 16, 2025
139 of 145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reble reble reble left review comments

@KFilipek KFilipek KFilipek approved these changes

@pbalcer pbalcer pbalcer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kswiecicki @pbalcer @reble @KFilipek