[Release/2.9] Revert "Roll back to original usage of sycl::get_kernel_bundle (#1935)" (#2026) #2035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous change to quickly resolve a performance regression caused by the usage of sycl::get_kernel_bundle. The revert restores the original implementation that includes device-specific kernel bundle retrieval to avoid runtime errors on devices other than the first device.
- Reverts the removal of device parameter in
sycl::get_kernel_bundlecall - Restores explanatory comments about the SYCL runtime limitation
- Addresses performance regression while maintaining multi-device compatibility
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
chuanqi129
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2026 to solve #2025.
This reverts commit 83a1555 to quickly bypass the performance regression caused by usage of sycl::get_kernel_bundle.