Fix: Incorrect Tensor Size for NestedTensor QKV Transform #2450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2182 The Q (Query) tensor output size from torch.transform_bias_rescale_qkv was mismatched against the expected reference size in test cases involving Nested Tensors where the sequence length (T) was not a multiple of 8 after implicit padding.
Resolution: The resolution involved introducing logic within the C++ function transform_bias_rescale_qkv_xpu specifically for the Nested Tensor case to explicitly use the calculated sequence length T to resize the output q, k, and v tensors, thereby ensuring their final size matches the shape derived by the Python reference implementation.