Add test_sycl_extension from test_cpp_extensions_aot for XPU by astachowiczhabana · Pull Request #2927 · intel/torch-xpu-ops

astachowiczhabana · 2026-02-25T08:28:56Z

Adds test_sycl_extension from upstream test_cpp_extensions_aot.py to XPU CI.

Unlike other _xpu tests that import upstream classes via XPUPatchForImport, this test requires AOT C++ extensions to be compiled first. The wrapper handles this by building them in setUpClass (mirroring upstream run_test.py logic), so no CI changes are needed.

Changes:

test/xpu/test_cpp_extensions_aot_xpu.py — self-contained wrapper that builds extensions and runs test_sycl_extension
test/xpu/skip_list_common.py — register new test file

Disable_e2e
Disable_distributed

Add a self-contained wrapper that builds the AOT C++ extensions in setUpClass and runs test_sycl_extension on XPU. Register the new test file in skip_list_common.py so it is picked up by run_test_with_skip.py in CI.

Copilot

Pull request overview

This PR adds an XPU-specific test wrapper intended to exercise the upstream-style AOT C++/SYCL extension build and run test_sycl_extension as part of XPU CI.

Changes:

Add test/xpu/test_cpp_extensions_aot_xpu.py to attempt building the SYCL AOT extension in setUpClass and run a basic sigmoid_add correctness check on XPU.
Register the new test file in the XPU test runner’s skip_dict so it is executed in XPU CI.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
`test/xpu/test_cpp_extensions_aot_xpu.py`	New wrapper test that attempts to build and import `torch_test_cpp_extension.sycl` before running an XPU correctness assertion.
`test/xpu/skip_list_common.py`	Adds the new test file to the XPU CI test list (`skip_dict`).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/xpu/test_cpp_extensions_aot_xpu.py

- Catch ModuleNotFoundError instead of broad ImportError - Remove try/except around build so failures surface as test errors - Defer sys.path insertion from import time to setUpClass

EikanWang · 2026-02-26T09:17:34Z

@astachowiczhabana , could you help add a dedicated section to the workflow for this case? Since we are suffering from a Windows CI issue, the test script of this PR cannot be verified. But a dedicated section like https://github.com/intel/torch-xpu-ops/blob/main/.github/workflows/_windows_ut.yml#L238-L251 before https://github.com/intel/torch-xpu-ops/blob/main/.github/workflows/_windows_ut.yml#L238C14-L238C37 could help workaround the Windows CI issue first to verify this PR.

astachowiczhabana · 2026-02-26T16:06:52Z

Thx @EikanWang for the review. I've added a dedicated "Run CPP Extensions AOT SYCL UT" step in _windows_ut.yml before the existing test steps, using pytest with --junit-xml for XML output collection.

github-actions · 2026-02-27T05:43:42Z

Performance outliers, please check!

🔴 [-1, 80%), should be regression

Category	Model	Target vs. Baseline [Eager]	Target vs. Baseline [Inductor]
torchbench_bfloat16_training	mnasnet1_0	0.95818	0.783364

🟡 [80%, 90%), may be fluctuations

Category	Model	Target vs. Baseline [Eager]	Target vs. Baseline [Inductor]
torchbench_bfloat16_training	dcgan	0.841575	0.804221
torchbench_bfloat16_training	resnet18	0.929294	0.836664
torchbench_bfloat16_training	resnext50_32x4d	0.955966	0.846038
torchbench_bfloat16_training	densenet121	0.814297	0.873977
torchbench_bfloat16_training	mobilenet_v3_large	0.964138	0.885686

.github/workflows/_windows_ut.yml

…test_xpu, add oneAPI env vars

github-actions · 2026-02-27T10:00:20Z

Performance outliers, please check!

🔴 [-1, 80%), should be regression

Category	Model	Target vs. Baseline [Eager]	Target vs. Baseline [Inductor]
torchbench_bfloat16_training	mnasnet1_0	0.967245	0.782921
torchbench_bfloat16_training	resnet18	0.909063	0.799914

🟡 [80%, 90%), may be fluctuations

Category	Model	Target vs. Baseline [Eager]	Target vs. Baseline [Inductor]
torchbench_bfloat16_training	dcgan	0.858456	0.810524
torchbench_bfloat16_training	densenet121	0.804364	0.851339
torchbench_bfloat16_training	resnext50_32x4d	0.953772	0.861319
torchbench_bfloat16_training	mobilenet_v3_large	0.964143	0.895925

dvrogozh

Why do we duplicate the test which is available in pytorch upstream? Is this a workaround for Windows CI?

github-actions · 2026-02-28T01:16:19Z

Performance outliers, please check!

🟡 [80%, 90%), may be fluctuations

Category	Model	Target vs. Baseline [Eager]	Target vs. Baseline [Inductor]
torchbench_bfloat16_training	resnet18	0.958637	0.835658
torchbench_bfloat16_training	mnasnet1_0	1.016375	0.883571

astachowiczhabana · 2026-03-03T12:51:46Z

Why do we duplicate the test which is available in pytorch upstream? Is this a workaround for Windows CI?

We don't have Windows tests in upstream

chuanqi129 · 2026-03-05T16:36:15Z

Hi @astachowiczhabana , seems the new added test case failed on Linux https://github.com/intel/torch-xpu-ops/actions/runs/22493742531/job/65192747065?pr=2927#step:4:3946, please double check it

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/_windows_ut.yml

test/xpu/test_cpp_extensions_aot_xpu.py

astachowiczhabana · 2026-03-06T07:19:32Z

@chuanqi129 Thanks for catching that. The test is no longer failing on Ubuntu — I've removed it from skip_list_common in the latest commit (adc0bdb), so it won't be picked up by the Ubuntu CI runner anymore. The test will now only run on Windows via the dedicated "Run CPP Extensions AOT SYCL UT" step in _windows_ut.yml.

We only need this test on Windows to verify that the upstream fix (pytorch/pytorch#175333) resolves the oneAPI 2025.3 build issue there. We don't need it on Ubuntu because test_sycl_extension already passes there in upstream CI. Once pytorch/pytorch#175333 is merged, we'll work on enabling Windows XPU CI in upstream as well.

github-actions · 2026-03-06T14:04:30Z

Performance outliers, please check!

🟡 [80%, 90%), may be fluctuations

Category	Model	Target vs. Baseline [Eager]	Target vs. Baseline [Inductor]
torchbench_bfloat16_training	resnet18	0.95936	0.898549

Add test_sycl_extension from test_cpp_extensions_aot for XPU

c08ecdd

Add a self-contained wrapper that builds the AOT C++ extensions in setUpClass and runs test_sycl_extension on XPU. Register the new test file in skip_list_common.py so it is picked up by run_test_with_skip.py in CI.

Copilot AI review requested due to automatic review settings February 25, 2026 08:28

Copilot started reviewing on behalf of astachowiczhabana February 25, 2026 08:29 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

Adam Stachowicz and others added 2 commits February 25, 2026 12:00

Address review: narrow exception handling, defer sys.path mutation

a9d697b

- Catch ModuleNotFoundError instead of broad ImportError - Remove try/except around build so failures surface as test errors - Defer sys.path insertion from import time to setUpClass

Merge branch 'main' into astachowiczhabana/issue2574

bdcb5ca

EikanWang added the windows_ci Only for Windows CI trigger label Feb 25, 2026

EikanWang approved these changes Feb 25, 2026

View reviewed changes

Merge branch 'main' into astachowiczhabana/issue2574

fc66b34

Adam Stachowicz and others added 3 commits February 26, 2026 17:52

Add dedicated Windows CI step for CPP Extensions AOT SYCL UT

5bc9d1e

Merge branch 'main' into astachowiczhabana/issue2574

61e507c

Add dedicated Windows CI step for CPP Extensions AOT SYCL UT

6be44d5

intel deleted a comment from github-actions bot Feb 27, 2026

chuanqi129 reviewed Feb 27, 2026

View reviewed changes

.github/workflows/_windows_ut.yml Outdated Show resolved Hide resolved

.github/workflows/_windows_ut.yml Show resolved Hide resolved

Address review: move SYCL UT step before Run Test XPU UT, trigger on …

d579695

…test_xpu, add oneAPI env vars

Fix Windows AOT build: set DISTUTILS_USE_SDK=1 when VC env is active

e4799f9

dvrogozh reviewed Feb 27, 2026

View reviewed changes

chuanqi129 approved these changes Mar 5, 2026

View reviewed changes

Remove unnecessary test from skip_list_common.py

adc0bdb

Copilot AI review requested due to automatic review settings March 6, 2026 00:32

Copilot started reviewing on behalf of astachowiczhabana March 6, 2026 00:32 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

.github/workflows/_windows_ut.yml Show resolved Hide resolved

test/xpu/test_cpp_extensions_aot_xpu.py Show resolved Hide resolved

test/xpu/test_cpp_extensions_aot_xpu.py Show resolved Hide resolved

Merge branch 'main' into astachowiczhabana/issue2574

3aa7996

Conversation

astachowiczhabana commented Feb 25, 2026 • edited by chuanqi129 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

EikanWang commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

astachowiczhabana commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 27, 2026

Performance outliers, please check!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 27, 2026

Performance outliers, please check!

Uh oh!

dvrogozh left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 28, 2026

Performance outliers, please check!

Uh oh!

astachowiczhabana commented Mar 3, 2026

Uh oh!

chuanqi129 commented Mar 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

astachowiczhabana commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 6, 2026

Performance outliers, please check!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

astachowiczhabana commented Feb 25, 2026 •

edited by chuanqi129

Loading

EikanWang commented Feb 26, 2026 •

edited

Loading

astachowiczhabana commented Feb 26, 2026 •

edited

Loading

astachowiczhabana commented Mar 6, 2026 •

edited

Loading