Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Correct homing description#75

Merged
ThatWileyGuy merged 1 commit intodevelopfrom
ThatWileyGuy-patch-1
Mar 10, 2018
Merged

Correct homing description#75
ThatWileyGuy merged 1 commit intodevelopfrom
ThatWileyGuy-patch-1

Conversation

@ThatWileyGuy
Copy link
Member

No description provided.

@ThatWileyGuy ThatWileyGuy merged commit 1044471 into develop Mar 10, 2018
@Wackerbarth
Copy link
Contributor

Wackerbarth commented Mar 11, 2018

The description seems to be correct. However, I find it still to be confusing. Unfortunately, the measurements are made in the reference frame of the endstop. I think that it would be easier to explain if the numbers were all in the bed reference. But that implies that we must negate the result. (But not the parking position which is in the bed coordinates)

@ThatWileyGuy
Copy link
Member Author

I agree - one of the ongoing efforts we have is to support "upgrading" a configuration in-place when a new version of Redeem starts up. One of the major reasons to do that was that our current endstop configuration is fairly confusing and it probably makes sense to design a more comprehensible one, but we needed a way to convert people from the old one to the new one rather than breaking all their configs.

@Wackerbarth
Copy link
Contributor

As for upgrading, we should add a "configuration version" to the system section of every file. And, if it is missing, default to the version as of redeem 2.0. Then, if the version is not "current", we can abort out (assuming that we get the configuration stuff that Daryl and I have been messing with -- it reverts to restarting with just the "default.cfg", and nothing else) and refer the user to an upgrade plugin.

@ThatWileyGuy
Copy link
Member Author

Yes, that's in-progress in #29 . Unfortunately, Andrew got busy and that PR has stalled somewhat.

@Wackerbarth Wackerbarth deleted the ThatWileyGuy-patch-1 branch March 14, 2018 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants