Officially support two-stage-bot, Trigger CI #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miselico
requested changes
Nov 23, 2023
src/schnapsen/bots/two_stage_bot.py
Outdated
| """Bot which plays first the one, than the other startegy""" | ||
|
|
||
| def __init__( | ||
| self, bot1: Bot, bot2: Bot, name: Optional[str] = "ProbabilityBot" |
Contributor
There was a problem hiding this comment.
can you remove this default value?
Contributor
|
I am overall in favor of having this. What I am a bit worried about is what to do with the trump and game end notification parts. This way they would go no-where, even if the underlying bots have an implementation. This would mean that these could not be used out of the box for things like training a ML bot. Second minor point is to immediately include the usage of this class in the test cases you refer to, to reduce code duplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've only used this in testing, but it turns out that this is a useful feature.