Conversation
Member
|
@ydah broadly looks good. I have some concern about memory bloat though, especially if for any reason the extra copy of the data doesn't get garbage collected promptly. Any thoughts on how we could mitigate that or at least identify if it is a real concern? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streaming response validation runs from a
Rack::BodyProxyclose callback and currently re-enumerates the original response body. Rack closes that body before invoking the callback, so one-shot bodies validate as empty and close-sensitive bodies raiseIOErrorafter the response has already been sent.Wrap streaming enumeration to collect the chunks yielded to the client, then validate those captured chunks from the close callback. The original response body is still closed before validation.