feat: add estimatedExchangeRate property to quote response#498
Closed
raducristianpopa wants to merge 5 commits intomainfrom
Closed
feat: add estimatedExchangeRate property to quote response#498raducristianpopa wants to merge 5 commits intomainfrom
estimatedExchangeRate property to quote response#498raducristianpopa wants to merge 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 12d3d6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for openpayments-preview canceled.
|
Comment on lines
1196
to
1199
| estimatedExchangeRate: | ||
| type: number | ||
| description: 'Estimated probed exchange rate over the path (ILP specific).' | ||
| readOnly: true |
Member
Author
There was a problem hiding this comment.
How will the estimatedExchangeRate be returned in this case? IIRC it should take into consideration exchange rate and fees (if they exist). Will this be computed on the RS and returned as a ready to use value for the consumer?
raducristianpopa
force-pushed
the
rp/491/update-quote-response
branch
from
7b582a7 to
ffd6ff7
Compare
Contributor
|
@raducristianpopa closing in favour of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
estimatedExchangeRatefor quotes #491Context