Prevent concurrency-related errors when saving server-side files when source control is enabled #1637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… source control is enabled
isc-rsingh
approved these changes
Aug 27, 2025
gjsjohnmurray
approved these changes
Aug 27, 2025
|
Thanks for the approval. I'm going to let Evan and his team play with this for another few days before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1632. I don't love making the post-save compilation a blocking part of our
writeFile()implementation, but VS Code's file system probing can cause errors when a document is being compiled post-save. This seems to be the best way to eliminate those errors, even if conceptually the save and compile are separate.