-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into private-memory-store
- Loading branch information
Showing
95 changed files
with
9,869 additions
and
1,351 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,6 +63,7 @@ jobs: | |
| run: | | ||
| echo "zpm \"install testcoverage\":1:1" > install-testcoverage | ||
| docker exec --interactive $instance iris session $instance -B < install-testcoverage | ||
| chmod 777 $GITHUB_WORKSPACE | ||
| - name: Build and Test | ||
| run: | | ||
|
|
@@ -72,7 +73,12 @@ jobs: | |
| echo "do \$System.OBJ.CompilePackage(\"$test_package\",\"ckd\") " > test.script | ||
| # Run tests | ||
| echo "zpm \"$package test -only $test_flags\":1:1" >> test.script | ||
| docker exec --interactive $instance iris session $instance -B < build.script && docker exec --interactive $instance iris session $instance -B < test.script &&bash <(curl -s https://codecov.io/bash) | ||
| docker exec --interactive $instance iris session $instance -B < build.script && docker exec --interactive $instance iris session $instance -B < test.script | ||
| - name: Upload coverage reports to Codecov with GitHub Action | ||
| uses: codecov/[email protected] | ||
| env: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | ||
|
|
||
| - name: Produce CE Artifact | ||
| run: | | ||
|
|
@@ -85,7 +91,7 @@ jobs: | |
| ls $GITHUB_WORKSPACE/$artifact_dir | ||
| - name: Attach CE Artifact | ||
| uses: actions/upload-artifact@v3 | ||
| uses: actions/upload-artifact@v4 | ||
| if: always() | ||
| with: | ||
| name: "PreIRISInstallationPackage" | ||
|
|
@@ -103,7 +109,7 @@ jobs: | |
| fail: false | ||
|
|
||
| - name: Attach the report | ||
| uses: actions/upload-artifact@v1 | ||
| uses: actions/upload-artifact@v4 | ||
| if: always() | ||
| with: | ||
| name: ${{ steps.xunit-viewer.outputs.report-name }} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # How to contribute | ||
|
|
||
| Thank you for your interest in contributing! While this project originated at InterSystems, it is our hope that the community will continue to extend and enhance it. | ||
|
|
||
| ## Submitting changes | ||
|
|
||
| If you have made a change that you would like to contribute back to the community, please send a [GitHub Pull Request](/pull/new/main) explaining it. If your change fixes an issue that you or another user reported, please mention it in the pull request. You can find out more about pull requests [here](http://help.github.com/pull-requests/). | ||
|
|
||
| Every pull request should include at least one entry in CHANGELOG.md - see [keepachangelog.com](https://keepachangelog.com/) for guidelines. | ||
|
|
||
| We encourage use of [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/). | ||
|
|
||
| ## Coding conventions | ||
|
|
||
| Generally speaking, just try to match the conventions you see in the code you are reading. For this project, these include: | ||
|
|
||
| * Do not use shortened command and function names - e.g., `s` instead of `set`, `$p` instead of `$piece` | ||
| * One command per line | ||
| * Do not use dot syntax | ||
| * Indentation with tabs | ||
| * Pascal case class and method names | ||
| * Avoid using postconditionals | ||
| * Local variables start with `t`; formal parameter names start with `p` | ||
| * Always check %Status return values | ||
|
|
||
| When making changes that involve JavaScript, ensure that your changes still work from Studio (which uses an old version of IE under the hood and therefore doesn't support various things you might take for granted). | ||
|
|
||
| Thank you! |
Oops, something went wrong.