Skip to content

Commit

Permalink
Merge pull request #698 from intersystems/prod-decomp-unc
Browse files Browse the repository at this point in the history
Fix parsing PTD items on network drive
  • Loading branch information
isc-tleavitt authored Jan 31, 2025
2 parents 37cacb5 + fa57544 commit d7f169e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed Import All options not importing the Embedded Git configuration file
- Improved performance of IDE editing and baselining of decomposed productions
- Fixed Discard / Stash not working on deletes (#688)
- Fixed errors deploying decomposed production changes on Windows network drives (#696)
- Improved performance of deploying changes to decomposed production items (#690)

## [2.9.0] - 2025-01-09
Expand Down
7 changes: 6 additions & 1 deletion cls/SourceControl/Git/Production.cls
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,12 @@ ClassMethod ParseExternalName(externalName, Output internalName = "", Output pro
} else {
if ##class(%File).Exists(externalName) {
// Special case for Config Item Settings PTD, requires checking PTD CDATA for Item and Class name
set deployDoc = ##class(EnsLib.EDI.XML.Document).%New(externalName)
// XML parser requires \\ instead of // for network directories
set deployDoc = ##class(EnsLib.EDI.XML.Document).%New($replace(externalName,"//","\\"))
if '$isobject(deployDoc) {
set sc = $$$ADDSC(%objlasterror,$$$ERROR($$$GeneralError,"Failed to create document"))
quit
}
set exportNotesPTDText = $ZCVT(deployDoc.GetValueAt("/Export/Document[1]/1"),"I","XML")
set exportNotesPTD = ##class(EnsLib.EDI.XML.Document).%New(exportNotesPTDText)
set productionName = exportNotesPTD.GetValueAt("/Deployment/Creation/SourceProduction")
Expand Down

0 comments on commit d7f169e

Please sign in to comment.