Skip to content

Fixes #655 #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Partial support for production decomposition with the new interoperability editors

### Fixed
- Changing system mode (environment name) in setting spersists after instance restart (#655)
- Popping from stash is more responsive (#687)
- Favorites links for Git pages now works on recent IRIS versions (#734)

Expand Down
2 changes: 1 addition & 1 deletion cls/SourceControl/Git/Settings.cls
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ Method %Save() As %Status
set @storage@("settings", "user", $username, "basicMode") = ..basicMode
}
try {
do $SYSTEM.Version.SystemMode(..environmentName)
do ##class(%zpkg.isc.sc.git.SystemMode).SetSystemMode(..environmentName)
} catch e {
// no-op; user might not have privileges.
}
Expand Down
23 changes: 23 additions & 0 deletions cls/_zpkg/isc/sc/git/SystemMode.cls
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
Class %zpkg.isc.sc.git.SystemMode
{
ClassMethod SetEnvironment(environment As %String) As %Status [ NotInheritable, Private ]
{
$$$AddAllRoleTemporary
do $SYSTEM.Version.SystemMode(environment)
new $namespace
set $namespace = "%SYS"
set obj = ##class(Config.Startup).Open()
set obj.SystemMode = environment
return obj.%Save()
}

ClassMethod SetSystemMode(environment As %String) As %Status [ NotInheritable ]
{
try {
do ..SetEnvironment(environment)
} catch e {
return e.AsStatus()
}
return $$$OK
}
}
2 changes: 1 addition & 1 deletion module.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<Document name="git-source-control.ZPM">
<Module>
<Name>git-source-control</Name>
<Version>2.10.0</Version>
<Version>2.11.0</Version>
<Description>Server-side source control extension for use of Git on InterSystems platforms</Description>
<Keywords>git source control studio vscode</Keywords>
<Packaging>module</Packaging>
Expand Down
Loading