Skip to content

Fix inconsistent casing in items cache #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

isc-pbarton
Copy link
Collaborator

Fixes #727

@isc-pbarton isc-pbarton marked this pull request as draft April 21, 2025 18:52
@isc-pbarton isc-pbarton force-pushed the fix-item-cache-case branch from 6ef27d4 to 79a0896 Compare April 21, 2025 19:29
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.37%. Comparing base (88fb29b) to head (09afb83).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Utils.cls 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
+ Coverage   41.30%   41.37%   +0.06%     
==========================================
  Files          24       24              
  Lines        3213     3210       -3     
==========================================
+ Hits         1327     1328       +1     
+ Misses       1886     1882       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isc-pbarton isc-pbarton force-pushed the fix-item-cache-case branch 2 times, most recently from 6b378dd to 74773eb Compare April 24, 2025 14:21
@isc-pbarton isc-pbarton marked this pull request as ready for review April 24, 2025 17:40
@isc-tleavitt
Copy link
Collaborator

@isc-pbarton there's a nontrivial merge conflict here - please resolve.

@isc-pbarton isc-pbarton force-pushed the fix-item-cache-case branch from a8740fd to 09afb83 Compare April 25, 2025 13:20
@isc-pbarton
Copy link
Collaborator Author

@isc-tleavitt Merge conflict has been resolved and retested now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent handling of file extensions
3 participants