Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): bump version of upload/donwload artifact to v4 #714

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

isc-shuliu
Copy link
Collaborator

Bump version of actions/upload-artifact and actions/download-artifact to v4

@isc-shuliu
Copy link
Collaborator Author

It seems that the syntax for the if is causing some problems.

On one hand

uses: actions/upload-artifact@v4
if: matrix.image == ${{ needs.prepare.outputs.main }}

causes all matrix jobs to run the upload-artifact step, leading to a name conflict.

On the other hand

uses: actions/upload-artifact@v4
if: ${{ matrix.image ==  needs.prepare.outputs.main }}

causes all matrix jobs to skip this step, leading to another problem during download-artifact

Will investigate futher

@isc-shuliu
Copy link
Collaborator Author

The CI files should be in good shape now.

Now we're dealing with a failed integration test on irishealth-community:2023.1. I'm unable to reproduce it on a container of the same tag locally. Might need to enable more verbose output during tests to investigate.

@isc-shuliu
Copy link
Collaborator Author

And it just magically recovered without any change. Will leave the debugging code in there in case it happens again in the future.

@isc-shuliu isc-shuliu merged commit 16e5512 into v0.10.x Jan 23, 2025
15 checks passed
@isc-shuliu isc-shuliu deleted the v0.10.x-ci-artifact-v4 branch January 24, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant