-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support publishing with static python dependency #720
base: v0.10.x
Are you sure you want to change the base?
Conversation
Discussed with @isc-shuliu today. Plan is:
|
Important caveat here for IPM itself: we should be able to say that installation will continue without error (and without installing the wheels) if pip isn't available. |
Developers should be responsible for placing python dependencies manually in the wheel files (or requirements.txt)
So far, After testing locally, the following packages have been successfully installed:
While these fails:
Will take a deeper look |
@isc-shuliu another thing to test here will be upgrading from a version of IPM without support - I think this should be OK but we need to double check. |
It appears the reconstructed wheel files from extracting the artifact xml are different from the original wheel files. For example, the original
But after bundled into
This causes But strangely, although the md5 changed, the wheel file remained zip-extractable as before! @isc-tleavitt Something must be going on when creating and/or extracting zpm.xml that caused the wheel file to change. |
@isc-shuliu I'm taking a look. |
@isc-tleavitt
I wonder if there's a (sort-of) alignment issue here |
Somewhere we're treating these as text files and putting Windows-style line endings on there!? |
... ok, we were doing that in parallel. Similar finding regardless and your way is better. :) |
Yes, it seems we are converting |
@isc-shuliu I think I got it... let's see how this CI does |
Re: 7fa5d33 good catch... fixed that in my exported installer XML and forgot to change the source |
See #698
This PR adds the ability to include python wheels in a package. Developers should be responsible for creating their own wheel and adding a
<PythonWheel />
entry inmodule.xml
.This PR also supports pure offline installation of the
oras
python package and its dependencies.Even if
pip
install of the wheel fails, the installation of IPM still continues.