Support for creating sitemaps #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpecha
reviewed
Mar 25, 2019
| class SitemapItem implements IFeedItem | ||
| { | ||
|
|
||
| /** @var string|int|NULL */ |
There was a problem hiding this comment.
Opravdu může být location typu int?
| { | ||
| Helpers::assert(isset($this->location), 'Missing item location, call $item->setLocation().'); | ||
| Helpers::assert(isset($this->lastModified), 'Missing item last modified date, call $item->setLastModified().'); | ||
| Helpers::assert(isset($this->priority), 'Missing item priority, call $item->setPriority().'); |
There was a problem hiding this comment.
Asi bych nevyžadoval nastavení lastModified a priority - podle https://www.sitemaps.org/protocol.html jsou tyto položky nepovinné. A u priority by asi bylo fajn kontrolovat jestli je hodnota (pokud je nastavena) ve správném rozsahu (od 0.0 do 1.0).
| * @param string | ||
| * @return self | ||
| */ | ||
| public function setLastModified($lastModified) |
There was a problem hiding this comment.
Co u lastModified místo stringu vyžadovat DateTimeInterface?
|
|
||
|
|
||
| /** | ||
| * @param string |
There was a problem hiding this comment.
Priorita by IMHO mohla akceptovat kromě stringu i float (resp. number)
added 4 commits
May 17, 2019 10:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.