templates: separate record detail content #2954
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR was automatically marked as stale. |
| <div class="ui container"> | ||
| <div class="ui relaxed grid mt-5"> | ||
| <div class="two column row top-padded"> | ||
| {% include "invenio_app_rdm/records/record_content.html" %} |
Contributor
There was a problem hiding this comment.
is the idea to make record_content.html overridable?
Contributor
Author
There was a problem hiding this comment.
I'd say embeddable instead of overridable. If you take a look at #2953, having the record content be separate would facilitate a tabbed interface for the landing page. There is probably more discussion needed on the specific interface....but I think this template change makes the templates more flexible in general.
Contributor
|
This PR was automatically marked as stale. |
4 tasks
Contributor
|
This PR was automatically marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
This PR splits the record detail template into the page template and a new template for the actual record content. This makes the template cleaner and more reusable, and is in preparation for being able to enhance the landing page in #2953
This PR does not make any changes to the templates, just splits the content into two.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: