Skip to content

fix(upgrade_scripts): Ignore deleted drafts #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sakshamarora1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(upgrade_scripts): Ignore deleted drafts #3238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion invenio_app_rdm/upgrade_scripts/migrate_13_0_to_14_0.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from invenio_db import db
from invenio_drafts_resources.resources.records.errors import DraftNotCreatedError
from invenio_rdm_records.proxies import current_rdm_records_service as records_service
from invenio_rdm_records.services.errors import RecordDeletedException
from invenio_search.api import RecordsSearchV2


Expand Down Expand Up @@ -93,7 +94,7 @@ def migrate_resource_type_in_record(record_id):
We go through the service layer to automatically trigger the DOI update and re-indexing.
"""
secho(f"Updating resource type for record {record_id}", fg="yellow")
record = records_service.read(system_identity, record_id)
record = records_service.read(system_identity, record_id, include_deleted=True)
if record.data["metadata"]["resource_type"][
"id"
] != "publication-thesis" and not any(
Expand Down Expand Up @@ -194,6 +195,10 @@ def migrate_resource_type_in_record(record_id):
system_identity, draft.id, draft.data
)
record = records_service.publish(system_identity, updated_draft.id)
except RecordDeletedException:
# If the draft was deleted, we ignore it
# In the future, we should add include_deleted to read_draft and update the draft metadata in these cases
secho(f"Draft <{draft.id}> has been deleted, skipping...", fg="yellow")

secho(f"Record <{record.id}> has been updated successfully.", fg="green")

Expand Down
Loading