Skip to content

Conversation

@Samk13
Copy link
Member

@Samk13 Samk13 commented Nov 24, 2025

❤️ Thank you for your contribution!

Description

Hopefully closes: #1414 🤞

This PR cleans up several deposit form fields and accordion behaviors to reduce confusion for new users.
In demos, users often try to fill optional fields (e.g., Alternate Identifier, Related works, ...) because the red star suggests they are required.
By removing showEmptyValue and keeping accordions closed when no data is present, the form shows fewer empty optional fields and avoids misleading cues.

Key points:

  • Prevents users from thinking optional fields are required.
  • Accordion sections stay inactive when empty.
  • Provides a cleaner and clearer initial form experience.

After:
Screenshot 2025-11-24 at 23 19 17

Before:

Screenshot 2025-11-24 at 23 20 52

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

* Prevent new users from mistaking the red star as a required
  for optional fields
* Default accordion fields to inactive
* Activate accordion when corresponding metadata arrays are non-empty
* Improve initial form UX
@Samk13 Samk13 force-pushed the change-accordion-default branch from eafe8e2 to a854dfa Compare November 24, 2025 22:13
@Samk13 Samk13 changed the title fix UX: update accordion default state to inactive Fix UX: Inactivate Optional Accordions When No Data Is Present Nov 24, 2025
@tmorrell
Copy link
Contributor

I'm 100% supportive of removing the blank fields which cause the confusing star to show up.

I think showing/hiding fields needs more community discussion. My opinion is funding and related works should be open, alternate identifiers and references closed.

I also think this is likely a v14 change.

@fenekku
Copy link
Contributor

fenekku commented Nov 25, 2025

just linking the related existing issue: #1414

@RosaLo
Copy link

RosaLo commented Dec 11, 2025

I agree with tmorrell that it would be good to have more community discussion on this. We reasoned that it would be logically consistent to have all sections that are non-obligatory "folded-in"/inactive accordions so that users shouldn't be confused with having non-obligatory fields marked with a * that we observed gave them a hint that they must fill in something in all of the fields with asterisk also in the non-obligatory sections. But there are surely several alternative ways to make the deposit form easier to understand for first-time end-users without losing options to add optional metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove fields in plain 'new upload' that look as they are required, but are not

4 participants