Skip to content

Safely create alembic_version table and add the correct stamps#202

Open
wgresshoff wants to merge 1 commit intoinveniosoftware:masterfrom
ulbmuenster:stamp-on-creation
Open

Safely create alembic_version table and add the correct stamps#202
wgresshoff wants to merge 1 commit intoinveniosoftware:masterfrom
ulbmuenster:stamp-on-creation

Conversation

@wgresshoff
Copy link

❤️ Thank you for your contribution!

Description

After a fresh setup of an InvenioRDM instance the alembic_version table was missing which leads to problems when migrating to a newer version. This PR adds a transaction context around the table creation and makes sure the correct connection is used, thus avoiding working in a connection ghost that never got committed.
This version reenables the cli tests.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@wgresshoff
Copy link
Author

Replaces #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant