Translations: add jinja and js translations #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pineirin
commented
Feb 14, 2023
Pineirin
commented
- closes: [BLOCKED] Add i18next translations #77
|
NOTE: invenio-i18n 108 this is removing flask-babelex. There are two options to handle this, merging this PR and creating a new PR which handles the changes, or changing this PR and wait for the invenio-i18n PR to be released |
|
@Pineirin how urgent is this? |
ntarocco
changed the title
|
@ntarocco i hope i will create the 3 last PR's today, then i will test it again on my local instance with all PR's and then i am ready. I think next week should be realistic. |
kpsherva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.