Skip to content

fix(tests): passing expires_at as datetime, not as string #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mesemus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(tests): passing expires_at as datetime, not as string #584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions tests/services/requests/test_requests_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ def test_check_expired_requests(
now = datetime.now(timezone.utc).replace(tzinfo=None)

# created only should not be picked up
created_request = create_request(
identity=identity_simple, expires_at=now.isoformat()
)
created_request = create_request(identity=identity_simple, expires_at=now)
Request.index.refresh()
check_expired_requests()
Request.index.refresh()
Expand Down Expand Up @@ -58,9 +56,7 @@ def test_check_expired_requests(
assert request_list.total == 0

# expiry date in future should not be touched
s2 = submit_request(
identity_simple, expires_at=(now + timedelta(days=1)).isoformat()
)
s2 = submit_request(identity_simple, expires_at=now + timedelta(days=1))
Request.index.refresh()
check_expired_requests()
Request.index.refresh()
Expand All @@ -75,7 +71,7 @@ def test_check_expired_requests(
)
assert request_list.total == 0

s3 = submit_request(identity_simple, expires_at=now.isoformat())
s3 = submit_request(identity_simple, expires_at=now)
Request.index.refresh()
check_expired_requests()
Request.index.refresh()
Expand Down
Loading