feat: add commit linter #13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # | ||
| # Copyright (C) 2024 CERN. | ||
| # Copyright (C) 2025 Graz University of Technology. | ||
|
|
||
| name: Python CI | ||
|
|
||
|
|
@@ -44,6 +45,9 @@ jobs: | |
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: commitlint | ||
| uses: wagoid/commitlint-github-action@v6 | ||
|
Member
There was a problem hiding this comment. minor: for 3rd-party action (i.e. those that are not under the "official" There was a problem hiding this comment. To be clear, using the commit hash is for security + breaking change shield purposes, right? As in, we use v6 and a rogue action update to 6.1 introduces a vulnerability or breaks the CI? (must admit that for our own repos and at least docs-invenio-rdm I haven't been that paranoid ) |
||
|
|
||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the default config is for
commitlint, but I see there are many of flexible options and even "shared configurations" (similar to ESLint).I would prefer that we have a "global" config with the set of allowed types (i.e.
chore,feat,fix, etc.). Regarding topics (i.e. whatever goes infix(<topic>): ...) I see that we:.commitlintrc?