Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CI #1520

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Fixed CI #1520

merged 4 commits into from
Sep 13, 2023

Conversation

dcavanagh
Copy link
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Updated docs / Refactor code / Added a tests case (non-breaking change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the changelog.

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #1520 (fe804df) into master (0b4a689) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master    #1520   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          53       53           
  Lines        1364     1364           
  Branches      196      196           
=======================================
  Hits         1358     1358           
  Partials        6        6           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jameskmonger
Copy link
Member

Jameskmonger commented Sep 12, 2023

Not sure if this is still needed @dcavanagh, CI seems to be working well on all PRs and the main repo.

I see there is some flakiness on the main branch .. is this PR related to that?

@PodaruDragos PodaruDragos merged commit d789647 into master Sep 13, 2023
10 checks passed
@PodaruDragos PodaruDragos deleted the dc/fix-ci branch September 13, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants