Add inRequestScope decorator inversify/InversifyJS/issues/678 #151
Conversation
| } | ||
|
|
||
| public done(force?: boolean) { | ||
| return this._provideDoneSyntax.done(force); | ||
| } | ||
|
|
||
| private provideWhenOnSyntax(bindingWhenOnSyntax: interfaces.BindConstraint) { |
There was a problem hiding this comment.
Pulled this out to reduce duplicate code
| expect(inTransientScopeExpectation.calledOnce).to.eql(true, "inTransientScope was not called exactly once"); | ||
| expect(mockBind.calledWith("Ninja")).to.be.eql(true, "mock bind was not called"); | ||
|
|
||
| ["inSingletonScope", "inRequestScope", "inTransientScope"].forEach(scope => { |
There was a problem hiding this comment.
I combined the shared aspects of the code into one repeated test (the equivalent of a data provider).
The weirdest part was calling provideInSyntax.in[...]Scope(). I haven't called a string as a function in typescript so I ended up defining it as an object with string keys to get around the no-implicit-any compiler issue. I'm open to other approaches.
|
@remojansen Just wanted to ping to see if there was anything else needed for this PR |
|
@dcavanagh Hey Dan! Would something like this go through you now? |
|
@remojansen @dcavanagh I'm also interested in this PR! Is there something that I can help? |
|
@jakehamtexas do you see any problems here, seems good to me at a first look. |
|
hi guys, can we merge this change in? |
|
Hmm inversify seems to be a dead project :( |
Description
This adds
inRequestScopesupport influentProvide.Related Issue
inversify/InversifyJS/issues/678
How Has This Been Tested?
inSingletonScopeandinTransientScopeto also includeinRequestScope.provide_in_syntax.test.tsrefactored to reduce duplicate code.Types of changes
Checklist: