Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adequate support for stream responses #326

Merged
merged 13 commits into from
Nov 25, 2023
Merged

Conversation

Foxy-Loxy
Copy link
Contributor

Added functionality of piping streamed responses without having to return callback with pipe in it

Description

Created new content type of StreamContent and added proper handle for it in server.ts on return

Related Issue

inversify/InversifyJS#850

Motivation and Context

Fixes the bug

How Has This Been Tested?

Unit test were written.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dcavanagh
Copy link
Member

@Foxy-Loxy will you please update this PR and resolve the conflicts? Thank you

@Foxy-Loxy
Copy link
Contributor Author

@dcavanagh , sorry for long delay in answer. I though that project is no longer maintained so never checked on PR. I did conflict resolvment and adapted new linter styles. Feel free to add any more inputs.

@Foxy-Loxy
Copy link
Contributor Author

@dcavanagh, I'm not sure if it's still relevant, but I've updated code to resolve all conflicts. Would be really cool if you, or anyone from maintainers would have time to check this out :)

Copy link
Contributor

@PodaruDragos PodaruDragos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@PodaruDragos
Copy link
Contributor

@dcavanagh after we merge this, can we also release with w/e is on master ?
It's been a very long time since we haven't released.

@Foxy-Loxy
Copy link
Contributor Author

Hi @dcavanagh @PodaruDragos ! Any chance that this PR goes anywhere?

@PodaruDragos PodaruDragos merged commit c3570bc into inversify:master Nov 25, 2023
@bhupesh-sf
Copy link

when will this be published on npm?

@Jameskmonger Jameskmonger added this to the 6.5.0 milestone Feb 14, 2024
@Jameskmonger
Copy link
Member

@bhupesh-sf I have added this to 6.5.0 milestone and it will be published in the next release, I will aim to make a release this week. Thank you and apologies for the delay.

@noahg
Copy link

noahg commented Apr 22, 2024

@Jameskmonger any update on the 6.5.0 release to npm? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants