-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adequate support for stream responses #326
Conversation
@Foxy-Loxy will you please update this PR and resolve the conflicts? Thank you |
@dcavanagh , sorry for long delay in answer. I though that project is no longer maintained so never checked on PR. I did conflict resolvment and adapted new linter styles. Feel free to add any more inputs. |
@dcavanagh, I'm not sure if it's still relevant, but I've updated code to resolve all conflicts. Would be really cool if you, or anyone from maintainers would have time to check this out :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
@dcavanagh after we merge this, can we also release with w/e is on master ? |
Hi @dcavanagh @PodaruDragos ! Any chance that this PR goes anywhere? |
when will this be published on npm? |
@bhupesh-sf I have added this to |
@Jameskmonger any update on the |
Added functionality of piping streamed responses without having to return callback with pipe in it
Description
Created new content type of StreamContent and added proper handle for it in
server.ts
on returnRelated Issue
inversify/InversifyJS#850
Motivation and Context
Fixes the bug
How Has This Been Tested?
Unit test were written.
Types of changes
Checklist: