Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React Native #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bai-jie
Copy link

@bai-jie bai-jie commented Jul 17, 2020

Support React Native

Description

_global in utils.ts is undefined on React Native(Android)

This bring TypeError at _global.window

Motivation and Context

React Native app isn't runnable if request something from conatiner when app start up (will encounter TypeError when start up).

How Has This Been Tested

  • app work normally after this change.
  • yarn test passed

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

_global is undefined on React Native
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant