Update license files and add copyright headers to all Dart files#163
Update license files and add copyright headers to all Dart files#163kevmoo wants to merge 5 commits intoinvertase:nextfrom
Conversation
|
In FlutterFire we are using this tool from Google to ensure Licence is up to date on all files: https://github.com/google/addlicense Wondering if this is what you used as well? |
|
@Lyokone – ha! Nope. I just asked Gemini to make me a script. |
5d03c82 to
558fdb7
Compare
It's considered very bad form to not have an upper bound
| # `google_cloud_storage` will not change the surface used by | ||
| # `dart_firebase_admin`. | ||
| google_cloud_storage: ">=0.5.1" | ||
| google_cloud_storage: ^0.5.1 |
There was a problem hiding this comment.
This is pretty important. We can't be casual here.
There was a problem hiding this comment.
Ah yes, this was the reason from Brian's comment in his PR #186 (comment).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #163 +/- ##
=======================================
Coverage ? 73.78%
=======================================
Files ? 105
Lines ? 6703
Branches ? 0
=======================================
Hits ? 4946
Misses ? 1757
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Are you just going to ditch this branch then? Is okay, just curious. |
Yup, if it's okay with you can I close this? |
No description provided.