Skip to content

Update license files and add copyright headers to all Dart files#163

Closed
kevmoo wants to merge 5 commits intoinvertase:nextfrom
kevmoo:license_and_copyright
Closed

Update license files and add copyright headers to all Dart files#163
kevmoo wants to merge 5 commits intoinvertase:nextfrom
kevmoo:license_and_copyright

Conversation

@kevmoo
Copy link
Collaborator

@kevmoo kevmoo commented Feb 10, 2026

No description provided.

@Lyokone
Copy link
Contributor

Lyokone commented Feb 10, 2026

In FlutterFire we are using this tool from Google to ensure Licence is up to date on all files: https://github.com/google/addlicense
https://github.com/firebase/flutterfire/blob/main/.github/workflows/all_plugins.yaml#L184-L205

Wondering if this is what you used as well?

@kevmoo
Copy link
Collaborator Author

kevmoo commented Feb 10, 2026

@Lyokone – ha! Nope. I just asked Gemini to make me a script.

@kevmoo kevmoo force-pushed the license_and_copyright branch from 5d03c82 to 558fdb7 Compare March 16, 2026 22:14
kevmoo added 2 commits March 16, 2026 15:31
It's considered very bad form to not have an upper bound
# `google_cloud_storage` will not change the surface used by
# `dart_firebase_admin`.
google_cloud_storage: ">=0.5.1"
google_cloud_storage: ^0.5.1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty important. We can't be casual here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, this was the reason from Brian's comment in his PR #186 (comment).

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (next@09d25a8). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #163   +/-   ##
=======================================
  Coverage        ?   73.78%           
=======================================
  Files           ?      105           
  Lines           ?     6703           
  Branches        ?        0           
=======================================
  Hits            ?     4946           
  Misses          ?     1757           
  Partials        ?        0           
Flag Coverage Δ
unittests 73.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@demolaf
Copy link
Member

demolaf commented Mar 17, 2026

Hi @kevmoo , we've decided to use google's addlicense tool like we do in our other projects #190 . Also included the changes you made in this PR.

@kevmoo
Copy link
Collaborator Author

kevmoo commented Mar 17, 2026

Are you just going to ditch this branch then? Is okay, just curious.

@demolaf
Copy link
Member

demolaf commented Mar 17, 2026

Are you just going to ditch this branch then? Is okay, just curious.

Yup, if it's okay with you can I close this?

@kevmoo kevmoo closed this Mar 17, 2026
@kevmoo kevmoo deleted the license_and_copyright branch March 17, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants