Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract tab content in remix prod #165

Merged
merged 1 commit into from
Apr 11, 2022
Merged

fix: extract tab content in remix prod #165

merged 1 commit into from
Apr 11, 2022

Conversation

cabljac
Copy link
Contributor

@cabljac cabljac commented Apr 11, 2022

  • with remix the output seems to be minified, and so name === TabItem is no longer valid. Just checking the name is truthy seems to work, but i'm not sure it works for all cases here

  • Fixes Tabs do not show content #162

@cabljac cabljac requested a review from Ehesp April 11, 2022 10:04
@cabljac cabljac merged commit 2297599 into main Apr 11, 2022
@cabljac cabljac deleted the fix-tabs branch April 11, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs do not show content
3 participants