-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use versions from firebase_core pubspec #351
base: main
Are you sure you want to change the base?
Conversation
This LGTM. CI fails because it is a fork. I ran tests locally and it was successful:
The most important test is this one: https://github.com/invertase/flutterfire_cli/blob/main/packages/flutterfire_cli/test/configure_test.dart#L1417-L1421 Which checks versions are ported over correctly. |
Wait until FlutterFire's next release before we merge this. |
Not blocked anymore -> firebase/flutterfire#16944 |
@frederikstonge - Actually, I think we should wait until the latest firebase_core has been adopted fully. If users haven't updated, it will use the old version. I'll give it another few weeks and then get this merged 😄 |
Description
There are TODO above gradle plugin versions of google services, crashlytics and performance to get them from the firebase_core pubspec definition.
❌❌ We might need to wait for this to be merged to avoid breaking changes : firebase/flutterfire#16944 ❌❌
Type of Change
feat
-- New feature (non-breaking change which adds functionality)fix
-- Bug fix (non-breaking change which fixes an issue)!
-- Breaking change (fix or feature that would cause existing functionality to change)refactor
-- Code refactorci
-- Build configuration changedocs
-- Documentationchore
-- Chore