Skip to content

fix: add underlyingException to FirebaseJsonException when projectId or appId are missing #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
russellwheatley merged 2 commits into from
Jan 23, 2025
Merged

fix: add underlyingException to FirebaseJsonException when projectId or appId are missing #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c511a1b
fix: add underlyingException to FirebaseJsonException when projectId …
Leedwon Jan 16, 2025
a7b0a4f
fix: ensure that underlyingException is printed when it's present
Leedwon Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/flutterfire_cli/lib/src/commands/upload_symbols.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,10 @@ class UploadCrashlyticsSymbols extends FlutterFireCommand {
}

if (projectId == null || appId == null) {
throw FirebaseJsonException();
final underlyingException =
Copy link
Contributor Author

@Leedwon Leedwon Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also thinking about adding a separate message for a case when both projectId and appId is missing, but I'm not sure if it's needed - worst case user will first see projectId is missing and then appId is missing

Copy link
Member

@russellwheatley russellwheatley Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this works 😄

projectId == null ? 'projectId is missing.' : 'appId is missing.';

throw FirebaseJsonException(underlyingException: underlyingException);
}

return ConfigurationResults(
Expand Down
2 changes: 1 addition & 1 deletion packages/flutterfire_cli/lib/src/common/strings.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ class FirebaseJsonException implements FlutterFireException {
final String? underlyingException;
@override
String toString() {
return 'FirebaseJsonException: Please run "flutterfire configure" to update the `firebase.json` at the root of your Flutter project with correct values. ${underlyingException != null ? '' : underlyingException}';
return 'FirebaseJsonException: Please run "flutterfire configure" to update the `firebase.json` at the root of your Flutter project with correct values. ${underlyingException ?? ''}';
}
}

Expand Down
Loading