Skip to content

fix(remote-config): type error in callback for modular onConfigUpdated #8614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bennettp123
Copy link

@bennettp123 bennettp123 commented Jul 15, 2025

Description

Update the type for the modular onConfigUpdated callback to match the existing type in the namespaced export

Related issues

Fixes #8613

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

before:

image

after:

image

Think react-native-firebase is great? Please consider supporting the project with any of the below:

🔥

Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2025 0:52am

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2025

CLA assistant check
All committers have signed the CLA.

@bennettp123 bennettp123 changed the title fix(remote-config): onConfigUpdated callback type error (#8613) fix(remote-config): type error in callback for modular onConfigUpdated Jul 15, 2025
@MichaelVerdon
Copy link
Collaborator

Thank you for this, looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] 🔥 remote-config: type mismatch between modular and namespaces onConfigUpdated
3 participants