fix(app): tolerate missing NativeError.userInfo property in NativeFirebaseError constructor
#8843
+28
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously a missing NativeError.userInfo would crash the constructor of NativeFirebaseError as it was expected to be defined with this change we will tolerate a completely missing userInfo property
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mikehardy
added
the
Workflow: Needs Review
8 tasks
russellwheatley
approved these changes
Jan 19, 2026
mikehardy
removed
the
Workflow: Needs Review
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apparently the userInfo property may be missing entirely on NativeError, but this wasn't safely handled in NativeFirebaseError
NativeError.userInfo === undefinedcase was handledRelated issues
Release Summary
fix release
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
I added a unit test to probe the condition as observed in reality, and it did fail prior to the changes here
I made the changes here and re-ran the test, and it passed
While running
yarn tests:jestI noticed some deprecation warnings in functions jest tests and repaired those in a separate commit since I was in the unit testing area...Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter