Skip to content

Conversation

@cabljac
Copy link
Collaborator

@cabljac cabljac commented Aug 27, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 27, 2025 15:47
@docs-page
Copy link

docs-page bot commented Aug 27, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/tanstack-query-firebase~222

Documentation is deployed and generated using docs.page.

@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2025

⚠️ No Changeset found

Latest commit: 106b3ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cabljac cabljac merged commit 547d5b1 into main Aug 27, 2025
2 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the package access level from restricted to public in the changeset configuration, enabling public distribution of packages.

  • Updates the access setting in changeset configuration from "restricted" to "public"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @cabljac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the .changeset/config.json file to change the default package access from "restricted" to "public". This ensures that packages managed by Changesets are published with public visibility, facilitating broader distribution and usage.

Highlights

  • Changesets Configuration: The "access" setting in .changeset/config.json has been updated from "restricted" to "public". This modification ensures that packages published via Changesets are publicly accessible.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@cabljac cabljac deleted the @invertase/access branch August 27, 2025 15:47
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the changesets configuration to set the default package access to public. While this change is simple, it has significant security implications. I have added one critical comment highlighting the risk of inadvertently publishing private packages. This change should be carefully considered to ensure it aligns with the repository's purpose and does not expose proprietary code.

"fixed": [],
"linked": [],
"access": "restricted",
"access": "public",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Setting the default access to public creates a significant risk of accidentally publishing private or proprietary packages. Any new package added to this repository will be publicly available by default upon publishing, unless its access level is explicitly overridden in its package.json. If this repository is intended to house any private packages, this default should remain restricted to prevent accidental data leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants