Changed time.sleep to condition.wait() #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time.sleep(n) is a kernel call that pauses the entire Python interpreter, Python threads a virtual. Using condition.wait(n) lets the other threads execute while waiting, this bypasses the GIL (global interpreter lock).
Added workflow to enable tests after commit.
|
Hi! This seems like an important update! I've collected some the PRs from this repo to https://github.com/leshchenko1979/reretry. If you could be so kind as to rebase your PR on that repo, I would gladly merge it there. |
Author
|
Added pull request with removal of prints and context manager changes, added a threaded test: #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time.sleep(n)is a kernel call that pauses the entire Python interpreter, Python threads a virtual. Usingcondition.wait(n)lets the other threads execute while waiting, this bypasses the GIL (global interpreter lock).Enabled tests to run after commit. Please say if you want me to redo the request without the tests, or ask to fix the tests if needed.
Created this pull request for leshchenko1979, https://github.com/brookman1/retry/tree/condition_wait
Thanks.