Skip to content

experiment(backend): autocast dtype in CustomLinear #7843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
from typing import TypeVar

import torch

T = TypeVar("T", torch.Tensor, None, torch.Tensor | None)


def cast_to_dtype(t: T, to_dtype: torch.dtype) -> T:
"""Helper function to cast an optional tensor to a target dtype."""
if t is None:
return t

if t.dtype != to_dtype:
return t.to(dtype=to_dtype)
return t
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import torch

from invokeai.backend.model_manager.load.model_cache.torch_module_autocast.cast_to_device import cast_to_device
from invokeai.backend.model_manager.load.model_cache.torch_module_autocast.cast_to_dtype import cast_to_dtype
from invokeai.backend.model_manager.load.model_cache.torch_module_autocast.custom_modules.custom_module_mixin import (
CustomModuleMixin,
)
Expand Down Expand Up @@ -73,6 +74,10 @@ def _autocast_forward_with_patches(self, input: torch.Tensor) -> torch.Tensor:
def _autocast_forward(self, input: torch.Tensor) -> torch.Tensor:
weight = cast_to_device(self.weight, input.device)
bias = cast_to_device(self.bias, input.device)

weight = cast_to_dtype(weight, input.dtype)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine, but some models may act weirdly due to potential precision loss if we provide inputs with less precision than the model 🤔 In an ideal world I'd think we'd want to ensure the precision of the inputs are compatible with the model before calling it

bias = cast_to_dtype(bias, input.dtype)

return torch.nn.functional.linear(input, weight, bias)

def forward(self, input: torch.Tensor) -> torch.Tensor:
Expand Down