-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(ui): Inpaint Mask Tools #8165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hipsterusername
wants to merge
27
commits into
main
Choose a base branch
from
Inpaint-mask-tools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kent <[email protected]>
Co-authored-by: kent <[email protected]>
This reverts commit 2952988.
This reverts commit f9a49e2.
Co-authored-by: kent <[email protected]>
Co-authored-by: kent <[email protected]>
This reverts commit 2952988.
This reverts commit f9a49e2.
3915d7f
to
46b91a0
Compare
…okeAI into Inpaint-mask-tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two new features to manage/improve Inpaint Masking experience:
WIP -- This is not done yet. There are some issues with how this actually technically works that are probably non-optimal, but can also cause issues when the bounding box moves and is inverted repeatedly. I don't anticipate that's the actual use case, but we can discuss after 6.0 goes out.
Related Issues / Discussions
Requests.
QA Instructions
Merge Plan
Checklist
What's New
copy (if doing a release after this PR)