-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat(ui): reverse queue list #8488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): reverse queue list #8488
Conversation
3f0c3b8
to
10e1b09
Compare
Some comments on the PR:
|
invokeai/frontend/web/src/features/queue/components/QueueList/QueueItemComponent.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/queue/components/QueueList/QueueList.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/queue/components/QueueList/QueueList.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/queue/components/QueueList/QueueList.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/queue/components/QueueList/types.ts
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/queue/components/QueueList/QueueItemComponent.tsx
Show resolved
Hide resolved
1732c30
to
c670aa7
Compare
@psychedelicious, I expect now |
There are issues with sorting on the
|
c670aa7
to
1244e5a
Compare
Ah, dang. We could fix the sorting such that we sort by the meaning of the status (i.e. pending, in progress, completed, failed, canceled) but the invalidation aspect is tricky. Let's make that column not sortable for now. |
@psychedelicious, how about |
I believe |
How about |
It looks like the whole slice can go now! The only other two things in it are |
1244e5a
to
7287197
Compare
|
|
b712864
to
618e2aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks!
70e124d
to
d2dab99
Compare
…QueueItemComponent.tsx Co-authored-by: psychedelicious <[email protected]>
…QueueList.tsx Co-authored-by: psychedelicious <[email protected]>
…QueueList.tsx Co-authored-by: psychedelicious <[email protected]>
makes it a bit less sluggish
d2dab99
to
771d316
Compare
Summary
A new feature was implemented to reverse queue list and virtualize the queue list
QUEUE_ORDER_BY
, was created insession_queue_common.py
to represent allowed sort columnsget_queue_itemIds
, was created inSessionQueueBase
for acquiring all queue item IDsget_queue_itemIds
, was created inSqliteSessionQueue
for acquiring all queue item IDsget_queue_item_ids
andget_queue_items_by_item_ids
, were created insession_queue_router
to expose the functionality of acquiring all queue item IDs and getting queue items by item IDsQueueItemComponent
changes:completedAt
field was added, whilebatchFieldValues
field was removed to adhere to new requirementsQueueItemPlaceholder
component was added to provide a placeholder icon while the queue item is being loadedQueueList
component was refactored to virtualize item loadingQueueListHeaderColumn
component was created to encapsulate sort related logic and componentsQueueListHeader
component was refactored to useQueueListHeaderColumn
componentsuseQueueItemIds
,useScrollableQueueList
anduseRangeBasedQueueItemFetching
, were created to virtualize the queue listsortBy
andsortOrder
, were added to queueSlice.ts to represent and persist sort related datagetQueueItemIds
andgetQueueItemDTOsByItemIds
, were added to queue.ts to expose virtualization related API endpointsschema.ts
was generated to include new virtualization related endpointsqueue.completedAt
,queue.sortColumn
,queue.sortBy
,queue.sortOrderAscending
andqueue.sortOrderDescending
, were added toen.json
Related Issues / Discussions
Closes #1234" format, so that the issue will be automatically closed when the PR merges.-->
Checklist
What's New
copy (if doing a release after this PR)