Skip to content

Conversation

psychedelicious
Copy link
Collaborator

Reverts #8536

Unfortunately it has a flaw. It thinks dynamically-constructed translation keys don't exist. For example, in the Canvas layers panel we do something like this:

const title = `controlLayers.${layerType}_withCount`

Then when the script checks for controlLayers.rasterLayers_withCount, it thinks the key isn't used. The keys is deleted and we see this in the UI:

image

Will need to return to the challenge of keeping translations cleaned up at a later date.

@github-actions github-actions bot added CI-CD Continuous integration / Continuous delivery frontend-deps PRs that change frontend dependencies frontend PRs that change frontend files labels Sep 5, 2025
@psychedelicious psychedelicious merged commit 26a3a91 into main Sep 8, 2025
13 checks passed
@psychedelicious psychedelicious deleted the revert-8536-psyche/tidy/ui/remove-unused-translations branch September 8, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-CD Continuous integration / Continuous delivery frontend PRs that change frontend files frontend-deps PRs that change frontend dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants