Skip to content

chore: replace dpdm with rev-dep (faster alternative for circular imports check) #8955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jayu wants to merge 2 commits into
base: main
Choose a base branch
from
+49 −208
Open

chore: replace dpdm with rev-dep (faster alternative for circular imports check) #8955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
400a935
chore: replace dpdm with rev-dep
jayu Mar 9, 2026
9d98d97
chore: add rev-dep to knip ignored deps
jayu Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/frontend-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:

- name: dpdm
if: ${{ steps.changed-files.outputs.frontend_any_changed == 'true' || inputs.always_run == true }}
run: 'pnpm lint:dpdm'
run: 'pnpm lint:circular'
shell: bash

- name: eslint
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ frontend-typegen:
frontend-lint:
cd invokeai/frontend/web/src && \
pnpm lint:tsc && \
pnpm lint:dpdm && \
pnpm lint:circular && \
pnpm lint:eslint --fix && \
pnpm lint:prettier --write

Expand Down
2 changes: 1 addition & 1 deletion docs/contributing/frontend/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Follow the [dev environment](../dev-environment.md) guide to get set up. Run the

- `dev`: run the frontend in dev mode, enabling hot reloading
- `build`: run all checks (dpdm, eslint, prettier, tsc, knip) and then build the frontend
- `lint:dpdm`: check circular dependencies
- `lint:circular`: check circular dependencies
- `lint:eslint`: check code quality
- `lint:prettier`: check code formatting
- `lint:tsc`: check type issues
Expand Down
2 changes: 1 addition & 1 deletion invokeai/frontend/web/CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ All commands should be run from `<REPO_ROOT>/invokeai/frontend/web/`.
- `pnpm lint:prettier`: check formatting
- `pnpm lint:eslint`: check for linting issues
- `pnpm lint:knip`: check for unused dependencies
- `pnpm lint:dpdm`: check for dependency cycles
- `pnpm lint:circular`: check for dependency cycles
- `pnpm lint:tsc`: check for TypeScript issues
- `pnpm lint`: run all checks
- `pnpm fix`: automatically fix issues where possible
Expand Down
4 changes: 2 additions & 2 deletions invokeai/frontend/web/knip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ const config: KnipConfig = {
'src/features/auth/**',
'src/services/api/endpoints/auth.ts',
],
ignoreBinaries: ['only-allow'],
ignoreDependencies: ['magic-string'],
ignoreBinaries: ['only-allow', 'rev-dep'],
ignoreDependencies: ['magic-string', 'rev-dep'],
paths: {
'public/*': ['public/*'],
},
Expand Down
4 changes: 2 additions & 2 deletions invokeai/frontend/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"typegen": "node scripts/typegen.js",
"preview": "vite preview",
"lint:knip": "knip --tags=-knipignore",
"lint:dpdm": "dpdm --no-warning --no-tree --transform --exit-code circular:1 src/main.tsx",
"lint:circular": "rev-dep circular --ignore-type-imports",
"lint:eslint": "eslint --max-warnings=0 .",
"lint:prettier": "prettier --check .",
"lint:tsc": "tsc --noEmit",
Expand Down Expand Up @@ -126,7 +126,6 @@
"@vitest/ui": "^3.1.2",
"concurrently": "^9.1.2",
"csstype": "^3.1.3",
"dpdm": "^3.14.0",
"eslint": "^9.31.0",
"eslint-plugin-i18next": "^6.1.2",
"eslint-plugin-import": "^2.29.1",
Expand All @@ -143,6 +142,7 @@
"openapi-types": "^12.1.3",
"openapi-typescript": "^7.6.1",
"prettier": "^3.5.3",
"rev-dep": "^2.11.0",
"rollup-plugin-visualizer": "^6.0.3",
"storybook": "^9.0.17",
"tsafe": "^1.8.5",
Expand Down
Loading