Skip to content

Fix misleading port numbers in Redis server error messages #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix misleading port numbers in Redis server error messages #3084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa9b9ff
Initial plan
Copilot Aug 31, 2025
ebc330b
Fix misleading port numbers in Redis server error messages
Copilot Aug 31, 2025
0afa81a
Merge branch 'master' into copilot/fix-3038
Apollon77 Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/db-objects-file/src/lib/objects/objectsInMemServerRedis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export class ObjectsInMemoryServer extends ObjectsInMemoryFileDB {
.then(() => {
this.log.debug(
`${this.namespace} ${settings.secure ? 'Secure ' : ''} Redis inMem-objects listening on port ${
settings.port || 9001
this.settings.connection.port || 9001
}`,
);

Expand All @@ -90,7 +90,7 @@ export class ObjectsInMemoryServer extends ObjectsInMemoryFileDB {
})
.catch(e => {
this.log.error(
`${this.namespace} Cannot start inMem-objects on port ${settings.port || 9001}: ${e.message}`,
`${this.namespace} Cannot start inMem-objects on port ${this.settings.connection.port || 9001}: ${e.message}`,
);
process.exit(EXIT_CODES.NO_CONNECTION_TO_OBJ_DB);
});
Expand Down
4 changes: 2 additions & 2 deletions packages/db-objects-jsonl/src/lib/objects/objectsInMemServerRedis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export class ObjectsInMemoryServer extends ObjectsInMemoryJsonlDB {
.then(() => {
this.log.debug(
`${this.namespace} ${settings.secure ? 'Secure ' : ''} Redis inMem-objects listening on port ${
settings.port || 9001
this.settings.connection.port || 9001
}`,
);

Expand All @@ -90,7 +90,7 @@ export class ObjectsInMemoryServer extends ObjectsInMemoryJsonlDB {
})
.catch(e => {
this.log.error(
`${this.namespace} Cannot start inMem-objects on port ${settings.port || 9001}: ${e.message}`,
`${this.namespace} Cannot start inMem-objects on port ${this.settings.connection.port || 9001}: ${e.message}`,
);
process.exit(EXIT_CODES.NO_CONNECTION_TO_OBJ_DB);
});
Expand Down
8 changes: 4 additions & 4 deletions packages/db-states-file/src/lib/states/statesInMemServerRedis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export class StatesInMemoryServer extends StatesInMemoryFileDB {
.then(() => {
this.log.debug(
`${this.namespace} ${settings.secure ? 'Secure ' : ''} Redis inMem-states listening on port ${
this.settings.port || 9000
this.settings.connection.port || 9000
}`,
);

Expand All @@ -78,7 +78,7 @@ export class StatesInMemoryServer extends StatesInMemoryFileDB {
})
.catch(e => {
this.log.error(
`${this.namespace} Cannot start inMem-states on port ${this.settings.port || 9000}: ${e.message}`,
`${this.namespace} Cannot start inMem-states on port ${this.settings.connection.port || 9000}: ${e.message}`,
);
process.exit(EXIT_CODES.NO_CONNECTION_TO_STATES_DB);
});
Expand Down Expand Up @@ -534,8 +534,8 @@ export class StatesInMemoryServer extends StatesInMemoryFileDB {
this.server = net.createServer();
this.server.on('error', err =>
this.log.info(
`${this.namespace} ${settings.secure ? 'Secure ' : ''} Error inMem-objects listening on port ${
settings.port || 9001
`${this.namespace} ${settings.secure ? 'Secure ' : ''} Error inMem-states listening on port ${
settings.port || 9000
}: ${err}`,
),
);
Expand Down
8 changes: 4 additions & 4 deletions packages/db-states-jsonl/src/lib/states/statesInMemServerRedis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export class StatesInMemoryServer extends StatesInMemoryJsonlDB {
.then(() => {
this.log.debug(
`${this.namespace} ${settings.secure ? 'Secure ' : ''} Redis inMem-states listening on port ${
this.settings.port || 9000
this.settings.connection.port || 9000
}`,
);

Expand All @@ -78,7 +78,7 @@ export class StatesInMemoryServer extends StatesInMemoryJsonlDB {
})
.catch(e => {
this.log.error(
`${this.namespace} Cannot start inMem-states on port ${this.settings.port || 9000}: ${e.message}`,
`${this.namespace} Cannot start inMem-states on port ${this.settings.connection.port || 9000}: ${e.message}`,
);
process.exit(EXIT_CODES.NO_CONNECTION_TO_STATES_DB);
});
Expand Down Expand Up @@ -534,8 +534,8 @@ export class StatesInMemoryServer extends StatesInMemoryJsonlDB {
this.server = net.createServer();
this.server.on('error', err =>
this.log.info(
`${this.namespace} ${settings.secure ? 'Secure ' : ''} Error inMem-objects listening on port ${
settings.port || 9001
`${this.namespace} ${settings.secure ? 'Secure ' : ''} Error inMem-states listening on port ${
settings.port || 9000
}: ${err}`,
),
);
Expand Down
Loading