feat: add ios implementation #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andredestro
force-pushed
the
feat/RMET-4046/implementation-ios
branch
3 times, most recently
from
77455ba to
ae4236c
Compare
andredestro
force-pushed
the
feat/RMET-4046/implementation-ios
branch
from
ae4236c to
4383aef
Compare
| ], | ||
| targets: [ | ||
| .binaryTarget( | ||
| name: "IONFileTransferLib", | ||
| // url: "https://github.com/ionic-team/ion-ios-filetransfer/releases/download/1.0.0/IONFileTransferLib.zip", | ||
| // checksum: "<compute_checksum>" // sha-256 | ||
| path: "./ios/Sources/FileTransferPlugin/IONFileTransferLib.xcframework" | ||
| path: "./ios/Sources/FileTransferPlugin/IONFileTransferLib.zip" |
There was a problem hiding this comment.
why are we using the .zip instead of the xcframework? Is this temporary?
There was a problem hiding this comment.
I was trying to build the example-app locally but it fails because of the reference to the IONFileTransferLib library, so it may be related with this.
Do you have an .ipa of the app that I can use to test? Or is there a build of an OutSystems app that I can use?
| shouldTrackProgress: Bool | ||
| ) -> (IONFLTRTransferResult) -> Void { | ||
| return { result in | ||
| if case let .ongoing(status) = result { |
There was a problem hiding this comment.
Can we use a switch statement instead?
| ) -> (IONFLTRTransferResult) -> Void { | ||
| return { result in | ||
| if case let .ongoing(status) = result { | ||
| if shouldTrackProgress { |
There was a problem hiding this comment.
We could use a guard instead of this if to avoid nesting, like:
guard shouldTrackProgress else { return }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.