ci: Native publishing fixes #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`semantic-release` in `release.plugin.yml` creates a commit that is necessary for the native publish (version update), but those workflows still reference the the (older) commit from triggering the release GitHub action. By pull, we make sure main is synced when trying to release.
OS-pedrogustavobilro
requested review from
ItsChaceD,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro,
jcesarmobile,
markemer and
theproducer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found a few issues that caused the publishing of the plugin to Maven Central and CocoaPods to fail:
semantic-release, found that the commit it was checking out was the one that existed when the GitHub action is triggered, and not the one after runningsemantic-release. This caused the workflow to try and publish a 8.0.0-next.X version to Maven Central / CocoaPods, which shouldn't happen.This PR fixes those issues.
Other changes outside this PR
Also, the sonatype staging id was wrong for this repo (and
capacitor-haptics) - updated the GitHub Action secret to fix this + There was an incorrect character in the signing key secret that also made release signing fail with Invalid key.Both of these were changed for capacitor-haptics and capacitor-keyboard.
Context
https://outsystemsrd.atlassian.net/browse/RMET-4860
Type of changes