-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(cli): Select a cap run target by target name #8199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
theproducer
wants to merge
6
commits into
main
Choose a base branch
from
RDMR-917
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−6
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9bfd674
add ability to select device target by name
theproducer 54afd88
Merge branch 'main' into RDMR-917
theproducer 19be785
removing log
theproducer 653db49
Adding missing return
theproducer 752ab24
Merge branch 'main' into RDMR-917
theproducer 5c4b872
Adding ability to further filter device target names by sdk version
theproducer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -234,6 +234,8 @@ export function runProgram(config: Config): void { | |
| .option('--list', 'list targets, then quit') | ||
| .addOption(new Option('--json').hideHelp()) | ||
| .option('--target <id>', 'use a specific target') | ||
| .option('--target-name <name>', 'use a specific target by name') | ||
| .option('--target-name-sdk-version <version>', 'use a specific sdk version when using --target-name') | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wonder if it's relevant providing examples of the SDK version format to use (assume it's the SDK int for Android and regular iOS version for iOS, but maybe worth making explicit)? |
||
| .option('--no-sync', `do not run ${c.input('sync')}`) | ||
| .option('--forwardPorts <port:port>', 'Automatically run "adb reverse" for better live-reloading support') | ||
| .option('-l, --live-reload', 'Enable Live Reload') | ||
|
|
@@ -246,7 +248,21 @@ export function runProgram(config: Config): void { | |
| config, | ||
| async ( | ||
| platform, | ||
| { scheme, flavor, list, json, target, sync, forwardPorts, liveReload, host, port, configuration }, | ||
| { | ||
| scheme, | ||
| flavor, | ||
| list, | ||
| json, | ||
| target, | ||
| targetName, | ||
| targetNameSdkVersion, | ||
| sync, | ||
| forwardPorts, | ||
| liveReload, | ||
| host, | ||
| port, | ||
| configuration, | ||
| }, | ||
| ) => { | ||
| const { runCommand } = await import('./tasks/run'); | ||
| await runCommand(config, platform, { | ||
|
|
@@ -255,6 +271,8 @@ export function runProgram(config: Config): void { | |
| list, | ||
| json, | ||
| target, | ||
| targetName, | ||
| targetNameSdkVersion, | ||
| sync, | ||
| forwardPorts, | ||
| liveReload, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.