add _alwaysRunsAtForegroundPriority setting #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I believe you need the keywindow changes from the original PR as well for proper background operation. |
Contributor
Author
|
Hi @ghenry22. I forked the current master, and realised the keywindow changes are already in the project, so no additional changes required. I guess there was another PR from before where it was added. Hopefully this PR will save you some time so that you don’t have to resolve conflicts. Thanks for your updates by the way! |
Contributor
|
ah right someone already cloned my selectable port PR and included the keywindow settings by the look of it. |
Contributor
|
Thanks! Merged and the other issue is closed |
|
There also is this PR that might have been missed: https://github.com/ionic-team/cordova-plugin-ionic-webview/pull/58/files :) |
This was referenced Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this updated PR on behalf of @ghenry22, since the original #45 had conflicts. (Literally just a copy and paste job)
Closes #45
Closes #57
@genry22 - if this has your blessing please comment here so that @mlynch can merge it.