Skip to content

docs(angular): show complete code context in the "Your First App" tutorial #4157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

docs(angular): show complete code context in the "Your First App" tutorial #4157

wants to merge 49 commits into from
+859 −222

Conversation

@soundproofboot
Copy link
Contributor

@soundproofboot soundproofboot commented Jun 17, 2025 •
edited by brandyscarney
Loading

resolves #2082

Changes

  • Update code blocks in first 5 pages of Angular Photo App tutorial to show additional context for each step with comments to indicate new lines.
  • Small changes to surrounding text for clarity.
  • Notes added linking to Angular documentation, localStorage and IndexedDB.

Preview

@soundproofboot soundproofboot requested a review from a team as a code owner June 17, 2025 18:22
@soundproofboot soundproofboot requested a review from gnbm June 17, 2025 18:22
@vercel
Copy link

vercel bot commented Jun 17, 2025

@soundproofboot is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-docs Ready Ready Preview Comment Oct 25, 2025 0:04am

@brandyscarney brandyscarney changed the title docs(angular): "Your First App" tutorial should show complete code context(#2082) docs(angular): show complete code context in the "Your First App" tutorial Jun 23, 2025
@brandyscarney brandyscarney requested review from thetaPC and removed request for gnbm June 23, 2025 15:28
thetaPC
thetaPC requested changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update Page 7 Live reload to include more complete code.

soundproofboot and others added 15 commits June 26, 2025 09:19
@soundproofboot @thetaPC
docs(angular): update code comment
19727c5 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
925be88 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
8311b56 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
dbba4e2 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
6a93709 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
6fb2f87 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
0bf8977 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
954c32b 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
318444e 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
2b7b188 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
3a30866 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
1a83529 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
9c926b4 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
082bdef 
Co-authored-by: Maria Hutt <[email protected]>
@soundproofboot @thetaPC
docs(angular): update code comment
ae805bb 
Co-authored-by: Maria Hutt <[email protected]>
thetaPC
thetaPC requested changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure to run npm run lint when you're done. That might be the reason that the checks are failing.

@soundproofboot soundproofboot requested a review from thetaPC June 30, 2025 14:41
@brandyscarney brandyscarney self-requested a review June 30, 2025 16:36
@gnbm gnbm requested review from ShaneK and removed request for thetaPC July 16, 2025 12:17
thetaPC
thetaPC approved these changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thetaPC thetaPC mentioned this pull request Sep 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPC thetaPC thetaPC approved these changes

@brandyscarney brandyscarney Awaiting requested review from brandyscarney

@ShaneK ShaneK Awaiting requested review from ShaneK

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Your First App" tutorial should show complete code context - Angular

2 participants

@soundproofboot @thetaPC