-
Notifications
You must be signed in to change notification settings - Fork 13.4k
chore(): add updated snapshots #30721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: FW-6747
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is expected now that the ionic
theme uses the dark palette.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test looks the same on next the screenshot just hasn't been updated: https://ionic-framework-git-next-ionic1.vercel.app/src/components/tab-bar/test/basic?ionic:theme=ionic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as some of those labels are supposed to be dark-on-dark, all the screenshots are there.
These are the screenshot updates for #30708
Most of these screenshots were updated because the
ionic
theme now uses the same colors as the other themes. I left comments on the ones that changed for other reasons explaining why.